Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(skeleton): skeleton component #1345

Merged
merged 2 commits into from
Feb 2, 2024
Merged

feat(skeleton): skeleton component #1345

merged 2 commits into from
Feb 2, 2024

Conversation

mengqiuleo
Copy link
Collaborator

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mengqiuleo
Copy link
Collaborator Author

Close #355

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

Close #355

@kagol kagol added the enhancement New feature or request label Jan 27, 2024
chenxi-20
chenxi-20 reviewed Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@chenxi-20 chenxi-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议先查看我的review建议~

@kagol
Copy link
Member

kagol commented Jan 27, 2024

@mengqiuleo 可否在PR中贴下组件效果图呢？

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

@mengqiuleo Can you post the component renderings in the PR?

@mengqiuleo
Copy link
Collaborator Author

@mengqiuleo 可否在PR中贴下组件效果图呢？

pr 预览的 github action 已经写好了，要不正好测一下写好的 github action 吧 @kagol

@kagol
Copy link
Member

kagol commented Jan 28, 2024

@mengqiuleo 可否在PR中贴下组件效果图呢？

pr 预览的 github action 已经写好了，要不正好测一下写好的 github action 吧 @kagol

好的，棒！

@mengqiuleo
Copy link
Collaborator Author

建议先查看我的review建议~

thanks, all fixed, please take a look.

@mengqiuleo
Copy link
Collaborator Author

@mengqiuleo 可否在PR中贴下组件效果图呢？

pr 预览的 github action 已经写好了，要不正好测一下写好的 github action 吧 @kagol
GIF 2024-1-29 21-47-28

@mengqiuleo mengqiuleo closed this Feb 2, 2024
@mengqiuleo mengqiuleo reopened this Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Deploy PR preview failed.

@kagol kagol merged commit 47c6f17 into opentiny:dev Feb 2, 2024
5 checks passed
fanbingbing16 pushed a commit to fanbingbing16/tiny-vue that referenced this pull request Feb 13, 2024
@mengqiuleo @fanbingbing16
feat(skeleton): skeleton component (opentiny#1345)
28209b0 
* feat(skeleton): skeleton component

* fix(skeleton): skeleton css style
@kagol kagol mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxi-20 chenxi-20 chenxi-20 left review comments

@kagol kagol kagol approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengqiuleo @Issues-translate-bot @kagol @chenxi-20