Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5649 Add SIP Video Outbound flag #227

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Oct 15, 2021

This PR provides clarity around use of the video option when making a SIP call using the Sip#dial method.

Description

Including '"video":"true" as part of the JSON payload for call to the /dial API endpoint allows video to be included in the OpenTok stream that is sent to the OpenTok session. This property can be included in the payload by adding it as an option in the opts hash passed to Sip#dial method. No changes were required to the implementation of the method, since the method can already accept video as a key in the opts hash (the method is very lenient with regards to keys that can be included in the hash).

The only changes were to the code comments in the Sip#dial method definition, and to the relevant specs.

Motivation and Context

Ongoing development to roll out new API features.

How Has This Been Tested?

Existing spec has been updated to include the option for video. Test suite has been run to pass.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Note: not technically a bug-fix, but not technically implementing a new feature either, but clarifies/ highlights the ability to use a new feature.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

pardel
pardel previously approved these changes Oct 15, 2021
Copy link
Contributor

@pardel pardel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you! 🙇

@SecondeJK SecondeJK self-requested a review October 15, 2021 14:57
SecondeJK
SecondeJK previously approved these changes Oct 15, 2021
Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But we should bump the version to 4.3.0 in ../lib/opentok/version.rb". Also, please target the dev branch. I have some docs edits (unrelated to this) that I would like to add. (I'll have a PR later today.)

@superchilled superchilled changed the base branch from main to dev October 18, 2021 14:36
@superchilled superchilled dismissed stale reviews from SecondeJK and pardel October 18, 2021 14:36

The base branch was changed.

@superchilled
Copy link
Contributor Author

@jeffswartz Have switched the base branch for the PR to dev. Regarding the version bump, this PR is going to be one of a number of updates over the next week or so. We're intending to bump the version once all the changes are in dev prior to release.

@superchilled superchilled requested a review from pardel October 18, 2021 14:41
@pardel pardel merged commit 1b8d286 into dev Oct 20, 2021
@pardel pardel deleted the devx-5649-add-sip-video-outbound-flag branch October 20, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants