-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVX-5649 Add SIP Video Outbound flag #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But we should bump the version to 4.3.0 in ../lib/opentok/version.rb". Also, please target the dev branch. I have some docs edits (unrelated to this) that I would like to add. (I'll have a PR later today.)
The base branch was changed.
@jeffswartz Have switched the base branch for the PR to |
This PR provides clarity around use of the
video
option when making a SIP call using theSip#dial
method.Description
Including
'"video":"true"
as part of the JSON payload for call to the/dial
API endpoint allows video to be included in the OpenTok stream that is sent to the OpenTok session. This property can be included in the payload by adding it as an option in theopts
hash passed toSip#dial
method. No changes were required to the implementation of the method, since the method can already acceptvideo
as a key in theopts
hash (the method is very lenient with regards to keys that can be included in the hash).The only changes were to the code comments in the
Sip#dial
method definition, and to the relevant specs.Motivation and Context
Ongoing development to roll out new API features.
How Has This Been Tested?
Existing spec has been updated to include the option for
video
. Test suite has been run to pass.Example Output or Screenshots (if appropriate):
Types of changes
Note: not technically a bug-fix, but not technically implementing a new feature either, but clarifies/ highlights the ability to use a new feature.
Checklist: