Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5663 Add SIP observeForceMute flag #232

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

superchilled
Copy link
Contributor

This PR provides clarity around use of the observe_force_mute option when making a SIP call using the Sip#dial method.

Description

Including '"observeForceMute":"true" as part of the JSON payload for call to the /dial API endpoint indicates whether the SIP end point observes force mute moderation. This property can be included in the payload by adding it as an option in the opts hash passed to Sip#dial method. No changes were required to the implementation of the method, since the method can already accept observe_force_mute as a key in the opts hash (the method is very lenient with regards to keys that can be included in the hash).

The only changes were to the code comments in the Sip#dial method definition, and to the relevant specs.

Motivation and Context

Ongoing development to roll out new API features.

How Has This Been Tested?

Existing spec has been updated to include the option for observe_force_mute. Test suite has been run to pass.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Note: not technically a bug-fix, but not technically implementing a new feature either, but clarifies/ highlights the ability to use a new feature.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

pardel
pardel previously approved these changes Oct 27, 2021
lib/opentok/sip.rb Outdated Show resolved Hide resolved
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
@superchilled superchilled requested a review from pardel November 4, 2021 10:54
@superchilled
Copy link
Contributor Author

@pardel I think this one is ready to merge now.

@pardel pardel merged commit 18a4a14 into dev Nov 5, 2021
@pardel pardel deleted the devx-5663-add-sip-observe-force-mute-flag branch November 5, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants