Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVX-5926 and DEVX-5937 Add dvr and lowlatency options for HLS Broadcasts #243

Merged
merged 5 commits into from
May 9, 2022
Merged

DEVX-5926 and DEVX-5937 Add dvr and lowlatency options for HLS Broadcasts #243

merged 5 commits into from
May 9, 2022

Conversation

superchilled
Copy link
Contributor

Description

  • Adds dvr and lowlatency options for hls Broadcast objects
  • Updates code comments for usage of these options
  • Adds a check that both are not set to true simultaneously

Motivation and Context

It implements a feature in the SDK which has already been added to the API.

How Has This Been Tested?

Added a test for the conditional check.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled changed the base branch from main to dev April 20, 2022 10:59
@superchilled superchilled marked this pull request as ready for review April 20, 2022 11:42
@superchilled superchilled requested a review from jeffswartz April 20, 2022 11:42
jeffswartz
jeffswartz requested changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rev the version number (to 4.4.0) in the lib/opentok/version.rb file.

@superchilled
Copy link
Contributor Author

Please rev the version number (to 4.4.0) in the lib/opentok/version.rb file.

👍🏾 Done in this commit

@superchilled superchilled merged commit f4d647d into dev May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffswartz jeffswartz jeffswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superchilled @jeffswartz