Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5908 Implement Audio Connector functionality #247

Merged
merged 7 commits into from
Mar 9, 2023

Conversation

superchilled
Copy link
Contributor

Description

  • Defines a WebSocket class which provides a connect method for connecting streams to a WebSocket URI
  • Updates the OpenTok and Client classes to work with the new WebSocket class
  • Defines a custom exception type OpenTokWebSocketError for WebSocket-specific issues
  • Adds a test for the WebSocket#connect method

Motivation and Context

It implements a feature in the SDK which is being added to the API.

How Has This Been Tested?

Added a test for the WebSocket#connect method

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

lib/opentok/websocket.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is currently in beta. Will it be shipping when this update to the Ruby SDK is released? If not, we should ship this with a beta release and mark it as beta (in the docs and in the release tag).

Also, will the REST API include get and list methods when this ships (after beta)? We should add methods for those.

@pardel
Copy link
Contributor

pardel commented Sep 27, 2022

@jeffswartz we'll keep this on-hold for now and will ship it sometime in Q4 one the feature is GA.

jeffswartz
jeffswartz previously approved these changes Sep 29, 2022
@superchilled superchilled changed the title DEVX-5908 Implement Audio Streamer (lite) functionality DEVX-5908 Implement Audio Connector functionality Feb 21, 2023
@superchilled superchilled requested a review from jeffswartz March 6, 2023 11:08
@superchilled superchilled merged commit 7573f63 into dev Mar 9, 2023
@superchilled superchilled deleted the devx-5908-audio-streamer-lite branch March 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants