Fix parsing of wheelchair accessible parking, add wheelchair debug layer #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6229 +/- ##
=============================================
+ Coverage 69.70% 69.73% +0.03%
- Complexity 17663 17680 +17
=============================================
Files 2007 2007
Lines 75732 75771 +39
Branches 7750 7754 +4
=============================================
+ Hits 52787 52842 +55
+ Misses 20229 20217 -12
+ Partials 2716 2712 -4 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
wheelchair-debug
branch
from
cde6aeb
to
fc286cd
Compare
leonardehrenfried
force-pushed
the
wheelchair-debug
branch
from
fc286cd
to
79221b6
Compare
optionsome
previously approved these changes
Nov 8, 2024
| @@ -23,7 +23,7 @@ export function GeometryPropertyPopup({ | |||
| {Object.entries(properties).map(([key, value]) => ( | |||
| <tr key={key}> | |||
| <th scope="row">{key}</th> | |||
| <td>{value}</td> | |||
| <td>{String(value)}</td> | |||
There was a problem hiding this comment.
@testower This is here so that booleans correctly show up in the frontend.
testower
approved these changes
Nov 12, 2024
optionsome
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the parsing of wheelchair accessible parking spaces (#6228) and adds a wheelchair-accessiblity debug layer, which looks like this
Issue
Closes #6228
Unit tests
Added.
Bumping the serialization version id
No.