Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location field: override icons (possibly using Slots pattern) #14

Closed
fpurcell opened this issue Jan 2, 2020 · 1 comment · Fixed by #29
Closed

location field: override icons (possibly using Slots pattern) #14

fpurcell opened this issue Jan 2, 2020 · 1 comment · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@fpurcell
Copy link
Member

fpurcell commented Jan 2, 2020

Our components will eventually need to allow the caller to override icons and other styling.

location-8

@fpurcell fpurcell added enhancement New feature or request altsource labels Jan 2, 2020
@fpurcell
Copy link
Member Author

Beyond using different sets of icons from the defaults used in otp-ui, there is a secondary need to broaden the icon pallet based on the 'layer' type of a given geocode record (e.g., from the list of records returned by the geocoder, 'addresses' type records will have a different icon from 'stop' records, which may be different from 'venues' / 'landmarks', etc...).

In the example below, the two stop records would get this icon:
image

...whereas, the other layer types would get another icon. (see #13 , which talks about returning more data from the geocoder, and #14 which talks about overriding the icons).

image

evansiroky added a commit to ibi-group/otp-ui that referenced this issue Jan 16, 2020
amy-corson-ibigroup added a commit that referenced this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants