TL/MLX5: fixes and Linter errors

openucx · May 18, 2023 · 877b091 · 877b091
1 parent 547e048
commit 877b091
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/components/tl/mlx5/tl_mlx5_context.c b/src/components/tl/mlx5/tl_mlx5_context.c
@@ -248,8 +248,7 @@ ucc_status_t ucc_tl_mlx5_context_create_epilog(ucc_base_context_t *context)
     status = tl_mlx5_create_rcache(ctx);
     if (UCC_OK != status) {
         tl_error(context->lib, "failed to create rcache");
-        goto out;
-
+        goto err;
     }
 
     ucc_free(sbcast_data);

diff --git a/src/components/tl/mlx5/tl_mlx5_rcache.c b/src/components/tl/mlx5/tl_mlx5_rcache.c
@@ -6,9 +6,10 @@
 
 #include "tl_mlx5.h"
 
-static ucs_status_t rcache_reg_mr(void *context, ucs_rcache_t *rcache,
-                                  void *arg, ucc_rcache_region_t *rregion,
-                                  uint16_t flags)
+static ucs_status_t
+rcache_reg_mr(void *context, ucs_rcache_t *rcache, //NOLINT: rcache is unused
+              void *arg, ucc_rcache_region_t *rregion,
+              uint16_t flags) //NOLINT: flags is unused
 {
     ucc_tl_mlx5_context_t *ctx      = (ucc_tl_mlx5_context_t *)context;
     void *                 addr     = (void *)rregion->super.start;
@@ -27,7 +28,8 @@ static ucs_status_t rcache_reg_mr(void *context, ucs_rcache_t *rcache,
     return UCS_OK;
 }
 
-static void rcache_dereg_mr(void *context, ucc_rcache_t *rcache,
+static void rcache_dereg_mr(void *        context, //NOLINT: context is unused
+                            ucc_rcache_t *rcache,  //NOLINT: rcache is unused
                             ucc_rcache_region_t *rregion)
 {
     ucc_tl_mlx5_reg_t *mlx5_reg = ucc_tl_mlx5_get_rcache_reg_data(rregion);