Skip to content

Commit

Permalink
V1.1.x CL/HIER: allreduce rab fix (#617)
Browse files Browse the repository at this point in the history
* TL/UCP: scatter kn fix

    Don't check for INPLACE in current implementation of scatter
    knomial. It is used specifically for bcast_sag which has no notion
    of INPLACE.

* CL/HIER: AVG not supported
  • Loading branch information
valentin petrov authored Sep 5, 2022
1 parent a09d56e commit 97f8008
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 4 additions & 1 deletion src/components/cl/hier/allreduce/allreduce_rab.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ UCC_CL_HIER_PROFILE_FUNC(ucc_status_t, ucc_cl_hier_allreduce_rab_init,
ucc_base_coll_args_t args;
int n_tasks, i;

if (coll_args->args.op == UCC_OP_AVG) {
return UCC_ERR_NOT_SUPPORTED;
}
schedule = &ucc_cl_hier_get_schedule(cl_team)->super.super;
if (ucc_unlikely(!schedule)) {
return UCC_ERR_NO_MEMORY;
Expand Down Expand Up @@ -88,7 +91,7 @@ UCC_CL_HIER_PROFILE_FUNC(ucc_status_t, ucc_cl_hier_allreduce_rab_init,
if (SBGP_ENABLED(cl_team, NODE) &&
cl_team->top_sbgp != UCC_HIER_SBGP_NODE) {
/* For bcast src should point to origin dst of allreduce */
args.args.src.info = args.args.dst.info;
args.args.src.info = args.args.dst.info;
args.args.coll_type = UCC_COLL_TYPE_BCAST;
status =
ucc_coll_init(SCORE_MAP(cl_team, NODE), &args, &tasks[n_tasks]);
Expand Down
5 changes: 0 additions & 5 deletions src/components/tl/ucp/scatter/scatter_knomial.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,6 @@ ucc_status_t ucc_tl_ucp_scatter_knomial_init_r(
ucc_rank_t rank = UCC_TL_TEAM_RANK(tl_team);
ucc_tl_ucp_task_t *task;

/* In place currently not supported */
if (UCC_IS_INPLACE(coll_args->args)) {
return UCC_ERR_NOT_SUPPORTED;
}

task = ucc_tl_ucp_init_task(coll_args, team);
task->super.post = ucc_tl_ucp_scatter_knomial_start;
task->super.progress = ucc_tl_ucp_scatter_knomial_progress;
Expand Down

0 comments on commit 97f8008

Please sign in to comment.