Skip to content

Commit

Permalink
REVIEW: code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
shimmybalsam authored and Sergei-Lebedev committed Aug 17, 2023
1 parent c22c6b8 commit bf870e9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
4 changes: 0 additions & 4 deletions src/components/tl/ucp/allgatherv/allgatherv.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ enum {
extern ucc_base_coll_alg_info_t
ucc_tl_ucp_allgatherv_algs[UCC_TL_UCP_ALLGATHERV_ALG_LAST + 1];

ucc_status_t ucc_tl_ucp_allgatherv_ring_start(ucc_coll_task_t *task);

void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *task);

ucc_status_t ucc_tl_ucp_allgatherv_ring_init_common(ucc_tl_ucp_task_t *task);

ucc_status_t ucc_tl_ucp_allgatherv_init(ucc_tl_ucp_task_t *task);
Expand Down
11 changes: 6 additions & 5 deletions src/components/tl/ucp/allgatherv/allgatherv_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *coll_task)

while (task->tagged.send_posted < tsize) {
send_idx =
ucc_ep_map_eval(task->subset.map,(trank -
task->tagged.send_posted + 1 +
tsize) % tsize);
ucc_ep_map_eval(task->subset.map, (trank -
task->tagged.send_posted + 1 +
tsize) % tsize);
data_displ = ucc_coll_args_get_displacement(
args, args->dst.info_v.displacements, send_idx) *
rdt_size;
Expand All @@ -47,8 +47,9 @@ void ucc_tl_ucp_allgatherv_ring_progress(ucc_coll_task_t *coll_task)
rmem, sendto, team, task),
task, out);
recv_idx =
ucc_ep_map_eval(task->subset.map,(trank -
task->tagged.recv_posted + tsize) % tsize);
ucc_ep_map_eval(task->subset.map, (trank -
task->tagged.recv_posted +
tsize) % tsize);
data_displ = ucc_coll_args_get_displacement(
args, args->dst.info_v.displacements, recv_idx) *
rdt_size;
Expand Down

0 comments on commit bf870e9

Please sign in to comment.