-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE: Use uint64_t for bitmap configs #1047
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, thanks
ok to test |
@andylin-hao Thanks. Which org do you represent? |
@manjugv Hi, I'm currently a PhD student (https://github.com/andylin-hao) researching on GPU communications. Just came across this problem when researching UCC/X out of curiosity. So I'm not really representing any specfic orgs in this case, though my official affiliation is with Tsinghua University. |
@andylin-hao Will you be able to sign a CLA? [1] Without that, we cannot accept the change. [1] https://github.com/openucx/ucc?tab=readme-ov-file#contributing |
@manjugv Sure, I just did. Could you let me know to whom should I send the signed CLA? |
@andylin-hao DM'ed you details. |
@manjugv @andylin-hao was the CLA signed - can we merge this? |
Yeah, I signed it. |
@janjust It was signed. |
What
Make the bitmap-type config
profile_mode
uint64_t to align with recent UCX(S) changes.Why ?
UCX(S) now uses uint64_t for bitmap-type (declared via UCS_CONFIG_TYPE_BITMAP) configurations (see openucx/ucx@8a84af8). UCC should align with this change, otherwise setting bitmap-type config may overwrite the next 4-byte memory during config parsing (see openucx/ucx@8a84af8#diff-8dd28fc04f39623f32e719552443482db8a07986754b3ba0ba48387db94d8bbdL446). In the case of UCC, the
profile_file
option ofucc_global_opts
will be overwritten whenprofile_mode
is set.