CORE: fix ucc parser build #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjugv
approved these changes
Oct 31, 2022
shimmybalsam
approved these changes
Oct 31, 2022
| ucs_status = ucs_config_parser_fill_opts(opts, fields, env_prefix, | ||
| table_prefix, ignore_errors); | ||
| status = ucs_status_to_ucc_status(ucs_status); | ||
| #if UCS_HAVE_CONFIG_GLOBAL_LIST_ENTRY_FLAGS |
There was a problem hiding this comment.
Perhaps change to UCC macro instead of UCS
There was a problem hiding this comment.
prefix is UCS because it depends on libucs similarly to UCS_HAVE_MPOOL_PARAMS
Sergei-Lebedev
force-pushed
the
topic/fix_parser_build
branch
from
2dd6c01 to
9440a68
Compare
|
bot:retest |
2 similar comments
|
bot:retest |
|
bot:retest |
bureddy
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Align ucc_config_parser_fill_opts with changes in UCS
openucx/ucx#8557
Why ?
Fixes UCC build with latest UCX