Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL/SHARP: fix assert check #686

Merged
merged 1 commit into from
Dec 6, 2022
Merged

TL/SHARP: fix assert check #686

merged 1 commit into from
Dec 6, 2022

Conversation

Sergei-Lebedev
Copy link
Contributor

What

fix sharp build

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/sharp_assert_fix branch 4 times, most recently from 3402a53 to 02753dd Compare December 6, 2022 07:25
@Sergei-Lebedev
Copy link
Contributor Author

also added build and clang-tidy checks for TL SHARP

vspetrov
vspetrov approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@vspetrov vspetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR also enables tl/sharp for triggered colls, right?

@Sergei-Lebedev
Copy link
Contributor Author

this PR also enables tl/sharp for triggered colls, right?

yes, do you think it might be an issue?

@Sergei-Lebedev Sergei-Lebedev merged commit b24612b into openucx:master Dec 6, 2022
@Sergei-Lebedev Sergei-Lebedev deleted the topic/sharp_assert_fix branch December 6, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspetrov vspetrov vspetrov approved these changes

@manjugv manjugv manjugv approved these changes

@bureddy bureddy Awaiting requested review from bureddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sergei-Lebedev @manjugv @vspetrov