EC/CUDA: remove if constexpr #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
approved these changes
Jan 25, 2023
| @@ -84,7 +84,7 @@ cuFloatComplex operator* (const cuFloatComplex & first, | |||
| } \ | |||
| _Pragma("unroll") for (i = 0; i < unroll; i++) \ | |||
| { \ | |||
| if constexpr (strided) { \ | |||
| if (strided) { \ | |||
There was a problem hiding this comment.
can we use function template specialiation to get same behaviour as if constexp?
template<bool strided>
void * get_tmp2(s, s2) {return nullptr}
template<>
void * get_tmp2(....)<true> {return s2[line + warp_size * i + j * ld]}
template<>
void * get_tmp2(....)<false> {return s[1 + j][line + warp_size * i]]}
shimmybalsam
approved these changes
Jan 25, 2023
bureddy
approved these changes
Jan 26, 2023
samnordmann
force-pushed
the
ec/cuda/refactor_remove_const_expr
branch
from
638d845 to
2aa43c7
Compare
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* EC/CUDA: remove if constexpr * EC/CUDA: remove constexpr specifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
remove "if constexpr" statements
No perf degradation, see graphs below
Why ?
causes a linter warning