TL/UCP: remove memcpy in last SRA step #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
force-pushed
the
topic/sra_opt
branch
from
d9a8f4e to
f0122dc
Compare
Sergei-Lebedev
requested review from
vspetrov,
bureddy,
manjugv and
shimmybalsam
shimmybalsam
approved these changes
Mar 20, 2023
vspetrov
reviewed
Mar 21, 2023
|
Discussed over phone with Sergey. He is to check if the change works correctly in the case when count % comm_size != 0. |
Sergei-Lebedev
force-pushed
the
topic/sra_opt
branch
2 times, most recently
from
3775da3 to
eb826bc
Compare
@vspterov, I've changed the way offsets are calculated please have a look |
manjugv
approved these changes
May 26, 2023
vspetrov
approved these changes
Jul 12, 2023
Sergei-Lebedev
force-pushed
the
topic/sra_opt
branch
from
eb826bc to
913811d
Compare
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Avoid memory copy in last step of reduce scatter.
How ?
In last step of reduce scatter local reduce operation is split into strided reduce of received data and reduce of result of that operation and local data.