TL/SHARP: SHARP OOB fixes #746
Conversation
bureddy
force-pushed
the
sharp-oob
branch
2 times, most recently
from
5d07eaa to
a5a3e16
Compare
| if(!sharp_ctx->cfg.enable_lazy_group_alloc) { | ||
| init_spec.config.flags |= SHARP_COLL_DISABLE_LAZY_GROUP_RESOURCE_ALLOC; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
print warning if disabling lazy group alloc is not supported by sharp and user has changed default value
There was a problem hiding this comment.
maybe we can expose the user option also only when flag is there
| @@ -30,7 +30,7 @@ static ucc_config_field_t ucc_tl_sharp_context_config_table[] = { | |||
| {"", "", NULL, ucc_offsetof(ucc_tl_sharp_context_config_t, super), | |||
| UCC_CONFIG_TYPE_TABLE(ucc_tl_context_config_table)}, | |||
|
|
|||
| {"DEVICES", "mlx5_0:1", | |||
| {"DEVICES", "", | |||
There was a problem hiding this comment.
how device will be selected for previous SHARP releases?
There was a problem hiding this comment.
it was sharplib user's responsibility to specify the device.. there is no default device selection
There was a problem hiding this comment.
right, this is my question, if one builds UCC 1.2 with SHARP 3.0 how it will work without providing device?
There was a problem hiding this comment.
the default selection was fixed in libsharp in the last HPCX release i. it will fail if we use older than that. that should be ok
- hide sharp lib errors - disable lazy init by default
Why ?