TL/SHARP: Prevent sharp team with team max ppn > 1 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjugv
approved these changes
Apr 10, 2023
| } | ||
|
|
||
| if (ucc_topo_max_ppn(self->topo) != 1) { | ||
| tl_info(ctx->super.super.lib, "sharp team not supported with ppn > 1"); |
|
|
||
| if (ucc_topo_max_ppn(self->topo) != 1) { | ||
| tl_info(ctx->super.super.lib, "sharp team not supported with ppn > 1"); | ||
| return UCC_ERR_NOT_SUPPORTED; |
There was a problem hiding this comment.
when return from team create function with error status you need to cleanup all resources allocated since destructor will not be called. Here need to free ucc_topo
| @@ -136,7 +138,8 @@ UCC_CLASS_INIT_FUNC(ucc_tl_sharp_team_t, ucc_base_context_t *tl_context, | |||
| goto cleanup; | |||
| } | |||
|
|
|||
| tl_debug(self->super.super.context->lib, "initialized tl team: %p", self); | |||
| tl_debug(self->super.super.context->lib, "initialized tl team: %p size:%d", | |||
| self, UCC_TL_TEAM_SIZE(self)); | |||
| return status; | ||
| } | ||
|
|
||
| if (ucc_topo_max_ppn(self->topo) != 1) { |
There was a problem hiding this comment.
should we make param for it? Do we sometimes want to allow sharp when ppn > 1?
|
bot:retest |
Sergei-Lebedev
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.