TL/MLX5: device memory and topo init #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
force-pushed
the
tl_mlx5/dm_alloc
branch
from
aefe1ab to
ab76282
Compare
samnordmann
changed the title
samnordmann
force-pushed
the
tl_mlx5/dm_alloc
branch
from
f82eb28 to
218d7b3
Compare
src/components/tl/mlx5/tl_mlx5_dm.c
Outdated
| status = ucc_mpool_init(&team->dm_pool, 0, sizeof(ucc_tl_mlx5_dm_chunk_t), | ||
| 0, UCC_CACHE_LINE_SIZE, cfg->dm_buf_num, | ||
| cfg->dm_buf_num, &ucc_tl_mlx5_dm_ops, | ||
| UCC_THREAD_MULTIPLE, "mlx5 dm pool"); |
There was a problem hiding this comment.
pls use actualy thread mode instead of UCC_THREAD_MULTIPLE
There was a problem hiding this comment.
can you confirm it is ok ?
shimmybalsam
approved these changes
May 23, 2023
samnordmann
force-pushed
the
tl_mlx5/dm_alloc
branch
2 times, most recently
from
3cb2c87 to
e99de8f
Compare
Sergei-Lebedev
approved these changes
May 29, 2023
samnordmann
force-pushed
the
tl_mlx5/dm_alloc
branch
from
73e0bfa to
d088d28
Compare
|
bot:retest |
bureddy
approved these changes
May 30, 2023
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TL/MLX5: device memory allocation * TL/MLX5: topo init * TL/MLX5: fix mask in wait-on-data WQE * TEST: update tl/mlx5 gtest * TL/MLX5: minor comments * TL/MLX5: minor revisions * TL/MLX5: gather global status after dm alloc * TL/MLX5: cleanup team if dm alloc fails * CODESTYLE: clang format * TL/MLX5: minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements device memory allocation and update the gtests
Also add topo init at team creation