TL/NCCL make ncclGroupEnd nb #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimmybalsam
force-pushed
the
nccl_nb_allgatherv_bug_fix
branch
7 times, most recently
from
6239705 to
90bbc66
Compare
|
bot:retest |
|
Can we abstract it better than having ifdef's all around the code? |
samnordmann
reviewed
Jun 27, 2023
@manjugv I abstracted/removed most of the branching, let me know what you think, thanks. |
shimmybalsam
force-pushed
the
nccl_nb_allgatherv_bug_fix
branch
from
2a87e41 to
7184609
Compare
samnordmann
approved these changes
Jun 27, 2023
manjugv
approved these changes
Jun 28, 2023
shimmybalsam
force-pushed
the
nccl_nb_allgatherv_bug_fix
branch
from
aff7789 to
16e8da7
Compare
|
bot:retest |
shimmybalsam
force-pushed
the
nccl_nb_allgatherv_bug_fix
branch
from
16e8da7 to
4808c81
Compare
shimmybalsam
force-pushed
the
nccl_nb_allgatherv_bug_fix
branch
from
4808c81 to
0e6b945
Compare
Sergei-Lebedev
approved these changes
Jul 18, 2023
jeniaka
pushed a commit
to jeniaka/ucc
that referenced
this pull request
Aug 14, 2023
* TL/NCCL: make ncclGroupEnd nb * REVIEW: review fixes * TL/NCCL: default blocking and configurable * REVIEW: second review fixes
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TL/NCCL: make ncclGroupEnd nb * REVIEW: review fixes * TL/NCCL: default blocking and configurable * REVIEW: second review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
check nccl status after using ncclGroupEnd , as well as for ncclSend/ncclRecv if they are called outside of ncclGroupStart/End.
Why ?
To fit nb change from using ncclCommInitRankConfig from PR #772