-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/UCP: reorder ranks for SRA #834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimmybalsam
force-pushed
the
reorder_ranks_SRA
branch
2 times, most recently
from
August 31, 2023 12:37
aaea7fe
to
bd5f180
Compare
bot:retest |
samnordmann
approved these changes
Sep 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we instead make map part of knomial pattern. That way we don't need to repeat ucc_ep_map_eval every time we get peer.
In future we can also add ring patter to do the same for ring algorithms
shimmybalsam
force-pushed
the
reorder_ranks_SRA
branch
from
September 6, 2023 14:29
bd5f180
to
a4b2a4f
Compare
bot:retest |
shimmybalsam
force-pushed
the
reorder_ranks_SRA
branch
from
September 11, 2023 14:26
a4b2a4f
to
995b22a
Compare
shimmybalsam
force-pushed
the
reorder_ranks_SRA
branch
2 times, most recently
from
September 27, 2023 07:04
d7857f5
to
137de91
Compare
Sergei-Lebedev
approved these changes
Oct 2, 2023
Sergei-Lebedev
force-pushed
the
reorder_ranks_SRA
branch
from
October 2, 2023 12:21
137de91
to
88ffed0
Compare
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add reorder ranks in for Allreduce SRA
Why ?
Performance benfit, especialy when n_extra ranks > 0, in which case we do a complete allreduce between "proxy" and "extra" ranks and if they are on the same node this significantly improves perf.
How ?
By reordring ranks in each step: reduce_scatter_knomial, allgather_knomial.
Note: allgather_knomial is used also for small message allgather and large message bcast (bcast SAG). In these cases reorder ranks will not be used, it is currently only implemented for the usage within allreduce SRA.