Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL/MLX5: add librdmacm linkage #905

Merged
merged 1 commit into from
Jan 25, 2024
Merged

TL/MLX5: add librdmacm linkage #905

merged 1 commit into from
Jan 25, 2024

Conversation

janjust
Copy link
Collaborator

@janjust janjust commented Jan 25, 2024

Sergei-Lebedev
Sergei-Lebedev approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix commit title e.g. "TL/MLX5: add librdmacm linkage"

@janjust janjust changed the title tlmlx5: add librdmacm linkage TL/MLX5: add librdmacm linkage Jan 25, 2024
@janjust
Copy link
Collaborator Author

janjust commented Jan 25, 2024

Done, fwiw, this change existed in the private repo and somehow never made it in during the numerous mcast mergers. I guess we don't have mcast enabled in our CI?

@Sergei-Lebedev
Copy link
Contributor

Done, fwiw, this change existed in the private repo and somehow never made it in during the numerous mcast mergers. I guess we don't have mcast enabled in our CI?

Right, MLX5 CI should work once #806 is merged

@Sergei-Lebedev
Copy link
Contributor

Done, fwiw, this change existed in the private repo and somehow never made it in during the numerous mcast mergers. I guess we don't have mcast enabled in our CI?

Need to change commit title to make CI happy, not PR title

@janjust
Copy link
Collaborator Author

janjust commented Jan 25, 2024

the force push was to change the title in the commit itself, not just in the PR

@Sergei-Lebedev
Copy link
Contributor

the force push was to change the title in the commit itself, not just in the PR

now it's good, thx

@artemry-nv
Copy link
Collaborator

bot:retest

1 similar comment
@artemry-nv
Copy link
Collaborator

bot:retest

@janjust
Copy link
Collaborator Author

janjust commented Jan 25, 2024

Why does this keep failing? Is it CI, or the patch itself (I can't imagine it being the patch)

@artemry-nv
Copy link
Collaborator

Why does this keep failing? Is it CI, or the patch itself (I can't imagine it being the patch)

Infra issues - Jenkins and K8s are under pressure due to release activities.

@B-a-S
Copy link
Collaborator

B-a-S commented Jan 25, 2024

bot:retest

@Sergei-Lebedev Sergei-Lebedev merged commit c8385d1 into openucx:master Jan 25, 2024
9 of 11 checks passed
@manjugv
Copy link
Contributor

manjugv commented Jan 31, 2024

Can you plz port into v1.3.0 branch? @janjust

janjust added a commit to janjust/ucc that referenced this pull request Jan 31, 2024
@janjust
TL/MLX5: ad librdmacm linkage (openucx#905)
5e077ae 
(cherry picked from commit c8385d1)
Signed-off-by: Tomislav Janjusic <tomislavj@nvidia.com>
@janjust
Copy link
Collaborator Author

janjust commented Jan 31, 2024

#910

Sergei-Lebedev pushed a commit that referenced this pull request Feb 1, 2024
@janjust
TL/MLX5: ad librdmacm linkage (#905) (#910)
ed65edf 
(cherry picked from commit c8385d1)
Signed-off-by: Tomislav Janjusic <tomislavj@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samnordmann samnordmann samnordmann approved these changes

@Sergei-Lebedev Sergei-Lebedev Sergei-Lebedev approved these changes

@bureddy bureddy Awaiting requested review from bureddy

Assignees
No one assigned
Labels
Ready-for-Review Target v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@janjust @Sergei-Lebedev @artemry-nv @B-a-S @manjugv @samnordmann