-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCT/IB/MLX5: Fasten DC support check #3301
Conversation
src/uct/ib/mlx5/ib_mlx5_dv.c
Outdated
srq_attr.attr.max_wr = 1; | ||
srq = ibv_create_srq(pd, &srq_attr); | ||
if (srq == NULL) { | ||
ucs_error("ibv_create_cq() failed: %m"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ibv_create_srq ?
attr.path_mtu = IBV_MTU_256; | ||
attr.ah_attr.port_num = 1; | ||
|
||
ret = ibv_modify_qp(qp, &attr, IBV_QP_STATE | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe extract new function just for testing if DC works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would entire old function.
Test FAILed. |
Test FAILed. |
src/uct/ib/mlx5/ib_mlx5_dv.c
Outdated
goto err; | ||
} | ||
|
||
attr.qp_state = IBV_QPS_RTR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
if (qp == NULL) { | ||
goto err_qp; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is not creating a qp enough to check DC support?
Why is it required to move it to RTR state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to RTR state triggers in kernel actual CREATE_DCT
Test PASSed. |
Test FAILed. |
No description provided.