Fix SPEC changelog, and check for warnings from rpmbuild - v1.8.x #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
reviewed
Jul 7, 2020
buildlib/azure-pipelines-pr.yml
Outdated
| container: fedora | ||
| steps: | ||
| - checkout: self | ||
| clean: true | ||
|
|
||
| - bash: ./autogen.sh | ||
| - bash: ./autogen.shq |
yosefe
force-pushed
the
topic/ci-check-for-warnings-from-rpmbuild
branch
from
226b6f8 to
26375ed
Compare
yosefe
changed the title
yosefe
changed the title
hoopoepg
approved these changes
Jul 7, 2020
mike-dubman
reviewed
Jul 7, 2020
| ./contrib/buildrpm.sh -s -t -b | ||
| displayName: Build tarball | ||
| stdbuf -e0 -o0 ./contrib/buildrpm.sh -s -t -b |& tee rpmbuild.log | ||
| pattern='^warning: ' |
There was a problem hiding this comment.
i dont think pattern ^warning: is correct, it searches from col #1 of str, while warning: in log file prefixed with file:line
There was a problem hiding this comment.
the log file does not have timestamp prefix (only AZP adds it later)
i any case, i've tested that when SPEC is wrong, it finds it: https://github.com/openucx/ucx/runs/845557002
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.