UCT/IB/DEVX: Set modify-QP global address parameters only for GRH case #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
reviewed
Dec 28, 2020
src/uct/ib/rc/accel/rc_mlx5_devx.c
Outdated
Comment on lines
384
to
392
| UCT_IB_MLX5DV_SET(qpc, qpc, primary_address_path.hop_limit, | ||
| ah_attr->grh.hop_limit); | ||
| memcpy(UCT_IB_MLX5DV_ADDR_OF(qpc, qpc, primary_address_path.rgid_rip), | ||
| &ah_attr->grh.dgid, | ||
| UCT_IB_MLX5DV_FLD_SZ_BYTES(qpc, primary_address_path.rgid_rip)); | ||
| /* TODO add flow_label support */ | ||
| UCT_IB_MLX5DV_SET(qpc, qpc, primary_address_path.tclass, | ||
| iface->super.super.config.traffic_class); | ||
| } |
There was a problem hiding this comment.
post-christmas indentation? :)
yosefe
force-pushed
the
topic/uct-ib-devx-set-modify-qp-global
branch
from
f33fef7 to
7949911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix modify_qp syndrome when passing ah_attr.tclass for IB port with is_global==0