TEST/UCP: Meet aligned_alloc requirements for requested size #9534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yosefe
reviewed
Dec 6, 2023
test/gtest/ucp/test_ucp_tag_xfer.cc
Outdated
|
|
||
| EXPECT_TRUE(ucs_is_pow2(chunk_size) && ucs_is_pow2(page_size)) << | ||
| "message size should be aligned to both page and chunk sizes"; | ||
| size_t alignment = ucs_max(chunk_size, page_size); |
There was a problem hiding this comment.
I think chunk_size may be not a power of 2 - if num_lanes is not a power of 2
maybe alignment = ucs_max(page_size, UCS_SYS_PCI_MAX_PAYLOAD) * num_lanes()
brminich
reviewed
Dec 7, 2023
ivankochin
commented
Dec 12, 2023
yosefe
previously approved these changes
Dec 12, 2023
brminich
previously approved these changes
Dec 12, 2023
ivankochin
force-pushed
the
test/ucp/align-msg-size-to-page
branch
from
02d3219 to
c110286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make message size divisible to page size.
Why ?
aligned_allocrequires that allocated size should be divisible to alignmentcppreference:
Found by ASAN.