Add checkmark to select explainer #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepharhar
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
|
I'm interested to here the reasoning for why ::before is easy but ::marker is hard? |
mfreed7
approved these changes
May 29, 2024
|
As it's currently implemented in chromium, setting display isn't allowed on ::marker I think. There also might be restrictions on which elements you can put ::marker on and how its rendered or what it renders. ::before on the other hand you can do whatever you want. I think it would be easier to create a new pseudo element than reuse ::marker, but I think that's another discussion we can have later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #863