Use dnf in dockerfile.redhat #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a mix of dnf and yum being used throughout the Dockerfile. This switches it over to only use dnf. As a result, yum-utils is not needed. This also adds more parallelism in downloads and more retries. The nvidia repo sometimes breaks connections. Hopefully the extra retries lets us be successful in setting up the build environment.
mzegla
reviewed
Sep 27, 2024
Comment on lines
-429
to
-442
| if [ "$INSTALL_RPMS_FROM_URL" == "" ] ; then \ | ||
| rpm -ivh http://vault.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/ocl-icd-2.2.12-1.el8.x86_64.rpm; \ | ||
| else \ | ||
| $DNF_TOOL install -y tar gzip; \ | ||
| mkdir /tmp_ovms ; \ | ||
| cd /tmp_ovms ; \ | ||
| curl -L --fail -o deps.tar.xz "$INSTALL_RPMS_FROM_URL" ; \ | ||
| tar -xf deps.tar.xz ; \ | ||
| ls -Rahl . ; \ | ||
| rpm -vi pkg/bin/*.rpm ; \ | ||
| cd / ; \ | ||
| rm -rf /tmp_ovms ; \ | ||
| $DNF_TOOL remove -y tar gzip; \ | ||
| fi ; \ |
There was a problem hiding this comment.
Don't we need this part anymore?
Comment on lines
-446
to
-447
| mkdir -p /ovms/lib/openvino-4.dist-info && \ | ||
| echo $'Metadata-Version: 1.0\nName: openvino\nVersion: 2024.4' > /ovms/lib/openvino-2024.4.dist-info/METADATA ; \ |
There was a problem hiding this comment.
Why do you remove these lines? I suppose we will loose capability of using openvino package in Python nodes if dist info is not created.
There was a problem hiding this comment.
we are setting it in https://github.com/openvinotoolkit/model_server/blob/main/Dockerfile.redhat#L305
This folder is not used
atobiszei
approved these changes
Sep 27, 2024
mzegla
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
🧪 Checklist
``