Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 4】Add paddle op mapper silu #15874

Merged
merged 6 commits into from
May 12, 2023
Merged

【PaddlePaddle Hackathon 4】Add paddle op mapper silu #15874

merged 6 commits into from
May 12, 2023

Conversation

FisherWY
Copy link
Contributor

Details:

  • Add paddle op mapper silu
  • Silu op is the same as swish op, the formulas of the two operators can be viewed in the following reference links

Tickets:

  • ticket-id

Reference

Test

image

@FisherWY FisherWY requested a review from a team as a code owner February 22, 2023 08:23
@github-actions github-actions bot added the category: PDPD FE OpenVINO PaddlePaddle FrontEnd label Feb 22, 2023
@ilya-lavrenov ilya-lavrenov added this to the 2023.0 milestone Feb 22, 2023
@openvino-dev-samples openvino-dev-samples mentioned this pull request Feb 22, 2023
Closed
@FisherWY FisherWY mentioned this pull request Feb 23, 2023
Closed
openvino-dev-samples
openvino-dev-samples reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@openvino-dev-samples openvino-dev-samples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FisherWY thanks for your contribution, looks the swish is same as silu, so it will be perfect if you can also help to map the swish as well.

@FisherWY
Copy link
Contributor Author

New test results:
image

@FisherWY
Copy link
Contributor Author

Hi @FisherWY thanks for your contribution, looks the swish is same as silu, so it will be perfect if you can also help to map the swish as well.

Op swish already mapped in this pr: #11661

@openvino-dev-samples
Copy link
Contributor

Hi @FisherWY thanks for your contribution, looks the swish is same as silu, so it will be perfect if you can also help to map the swish as well.

Op swish already mapped in this pr: #11661

I see, thanks

@ilya-lavrenov ilya-lavrenov added ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event labels Mar 4, 2023
@Ligoml Ligoml mentioned this pull request Mar 7, 2023
Closed
@yuxu42 yuxu42 requested a review from xczhai April 23, 2023 03:28
@yuxu42
Copy link
Contributor

yuxu42 commented Apr 23, 2023

@xczhai Could you please take a review? Thanks!

@ilya-lavrenov ilya-lavrenov modified the milestones: 2023.0, 2023.1 Apr 24, 2023
@xczhai xczhai self-requested a review May 9, 2023 01:33
@xczhai xczhai assigned xczhai and unassigned xczhai May 9, 2023
xczhai
xczhai approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@xczhai xczhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openvino-comment-bot
Copy link

Can one of the admins verify this patch?

@ceciliapeng2011 ceciliapeng2011 merged commit 99a7fa1 into openvinotoolkit:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliapeng2011 ceciliapeng2011 ceciliapeng2011 approved these changes

@openvino-dev-samples openvino-dev-samples openvino-dev-samples approved these changes

@xczhai xczhai xczhai approved these changes

Assignees
No one assigned
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event
Projects
None yet
Milestone
2023.1
Development

Successfully merging this pull request may close these issues.
7 participants
@FisherWY @openvino-dev-samples @yuxu42 @openvino-comment-bot @ceciliapeng2011 @xczhai @ilya-lavrenov