Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF FE] Support complex tensors for ScatterNd operations #23356

Closed
wants to merge 7 commits into from
Closed

[TF FE] Support complex tensors for ScatterNd operations #23356

wants to merge 7 commits into from

Conversation

MonalSD
Copy link
Contributor

@MonalSD MonalSD commented Mar 10, 2024

Details:

  • Extended loader ScatterNd by propagating ComplexTypeMark from input to output and to represent output complex type tensor as a floating-point type tensor with an auxiliary dimension that concatenates real and imaginary parts of complex tensor.
  • Wrapped the complex result with ComplexTypeMark and returned the result

Tickets:

@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Mar 10, 2024
@MonalSD
Copy link
Contributor Author

MonalSD commented Mar 11, 2024

Hi @rkazants please do check the changes. Thanks

@mlukasze mlukasze added the ExternalPR External contributor label Mar 11, 2024
@MonalSD MonalSD marked this pull request as ready for review March 11, 2024 07:39
@MonalSD MonalSD requested a review from a team as a code owner March 11, 2024 07:39
rkazants
rkazants requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix

@rkazants rkazants self-assigned this Mar 11, 2024
@rkazants rkazants linked an issue Mar 11, 2024 that may be closed by this pull request
[Good First Issue][TF FE]: Support complex tensors for ScatterNd operations #23240
Closed
@MonalSD
Copy link
Contributor Author

MonalSD commented Mar 14, 2024

@rkazants addressed the changes. Please do give a look

@rkazants rkazants changed the title Support complex tensors for ScatterNd operations [TF FE] Support complex tensors for ScatterNd operations Mar 14, 2024
@MonalSD
Copy link
Contributor Author

MonalSD commented Mar 31, 2024

@rkazants please give your inputs to proceed.

rkazants
rkazants reviewed Apr 7, 2024
View reviewed changes
src/frontends/tensorflow_common/src/op/scatter_nd.cpp Outdated
Comment on lines 29 to 32
Shape shape_dims = shape.get_shape();
shape_dims.insert(shape_dims.begin(), 2);
auto aux_shape = create_same_type_const<int32_t>(shape, std::vector<int32_t>{2}, Shape{1});
auto updated_shape = make_shared<v0::Concat>(OutputVector{aux_shape, shape}, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please construct a graph using ShapeOf and Concat operations to append auxiliary dimension

rkazants
rkazants reviewed Apr 7, 2024
View reviewed changes
src/frontends/tensorflow_common/src/op/scatter_nd.cpp Outdated
auto aux_shape = create_same_type_const<int32_t>(shape, std::vector<int32_t>{2}, Shape{1});
auto updated_shape = make_shared<v0::Concat>(OutputVector{aux_shape, shape}, 0);

auto input_data = create_same_type_const<int32_t>(updates, vector<int32_t>{0}, Shape{1});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a scalar = 0 of the same type as updates

@MonalSD
Copy link
Contributor Author

MonalSD commented Apr 8, 2024

@rkazants addressed the changes please give it a look.

@MonalSD
Copy link
Contributor Author

MonalSD commented Apr 21, 2024

@rkazants please review the changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants requested changes

Assignees

@rkazants rkazants

Labels
category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support complex tensors for ScatterNd operations
3 participants
@MonalSD @rkazants @mlukasze