Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin for cheqd method support #1307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sownak
Copy link

@sownak sownak commented Dec 20, 2024

PR for new Plugin to enable support for did:cheqd in ACA-Py.

  • Unit Tests coverage > 90%
  • Integration Tests included
  • Postman collection also included

NOTE
Only open item is that this refers to a develop branch for the core ACAPY changes, this will be updated when the latest version of ACAPY is released.

Also includes contributions by @DaevMithran

Signed-off-by: Sownak Roy <sownak@cheqd.io>
@jamshale
Copy link
Contributor

So the auto create plugin script you used needs to be updated. Originally I thought most of the plugins were going to be protocols.

You can delete the definition.py file and then move the plugin code up a level from the v1_0 folder.

Then in places where the agent uses the --plugin config the plugin name would be cheqd instead of cheqd.v1_0.

Sorry about that. Hope it's not too much work to update, and I'll try and update the script to avoid this for the next person.

@jamshale
Copy link
Contributor

Did a quick over and it's looking really good 👍 Will try and find some time to go over it closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants