fix: return tag_value if no value_key #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes what seems to have been a bug in the handling of plaintext tags Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
ianco
approved these changes
Mar 2, 2023
andrewwhitehead
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what seems to have been a bug in the handling of plaintext tags.
@andrewwhitehead this line was one we happened to inherit 🙂 I believe these changes captured the intended function of this method but a double check from you would be appreciated, if you get a chance.
Plaintext tags are not well used (I don't think they're used at all in ACA-Py) which let this bug slip past our testing which operates exclusively on ACA-Py wallets.
@blu3beri this also relates to a
TODOline I noticed in openwallet-foundation/askar#104 where you asked whattag[1]represented. I wasn't sure which lead to the discovery of this bug 🙂