Don't pass rekey to sub_wallet_profile #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
approved these changes
Nov 12, 2024
dbluhm
force-pushed
the
rekey-multitenancy
branch
from
3888ec0
to
61a2a82
Compare
Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>
dbluhm
force-pushed
the
rekey-multitenancy
branch
from
61a2a82
to
e59d275
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be all that is needed to allow multitenancy single wallet mode to work with the rekey feature. In single wallet mode the multitenant_sub_wallet is always created without a key. I guess this is ok because the subwallets should have a key.
When the rekey feature was applied it would send the new key to try to open the multitenant_sub_wallet, resulting in a failure to open the wallet.
There is other work to be done here. Right now in single wallet mode it is possible to make subwallets without a key and there is no rekey feature for subwallets. See #3307