fix(js): empty key entry list metadata in react-native #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
genaris
changed the title
Closed
berendsliedrecht
previously approved these changes
Mar 2, 2023
| @@ -1016,7 +1016,7 @@ jsi::Value keyEntryListGetMetadata(jsi::Runtime &rt, jsi::Object options) { | |||
| askar_key_entry_list_get_metadata(keyEntryListHandle, index, &out); | |||
| handleError(rt, code); | |||
|
|
|||
| return jsi::String::createFromAscii(rt, out); | |||
| return jsi::String::createFromAscii(rt, out ? out : "{}"); | |||
There was a problem hiding this comment.
Suggested change
| return jsi::String::createFromAscii(rt, out ? out : "{}"); | |
| if out == nullptr { | |
| return jsi::Value::null(); | |
| } else { | |
| return jsi::String::createFromAscii(rt, out); | |
| } |
There was a problem hiding this comment.
I changed the return type as suggested, and did the same with entryListGetValue and entryListGetTags. Seems to be working fine with the RN sample app from test repo.
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
berendsliedrecht
approved these changes
Mar 5, 2023
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…undation#105) Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a crash when fetching an existing key in iOS (and likely also in Android) and
askar_key_entry_list_get_metadatareturns NULL:Not sure if the same should be applied to other parts of the code (it was already done in some other methods such as
entryListGetTagsandkeyEntryListGetTags).