fix(js): free key and entry objects #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Closed
|
It looks like EntryLists are freed in the Scan implementation which is good as well. It seems fairly easy for a user to accidentally leak sessions and run out of active connections though, it might be better to use a callback interface for working with open sessions and transactions, and close automatically after it runs. |
berendsliedrecht
approved these changes
Mar 2, 2023
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…jects fix(js): free key and entry objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is not a destructor in JS, objects must be freed manually. This PR attempts to free any native object after it is used, making life easier to consumer applications.
If this approach is correct, the only objects an app using this library should care about is
Key(for which I added the missing call tokeyFree).@blu3beri let me know if concepts applied here are correct so I can replicate for anoncreds-rs.