fix(js): ensure scan is freed after fetchAll #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
TimoGlastra
approved these changes
Mar 6, 2023
|
We have fixed the error being thrown when no record being found (in a local branch), but this fix is good either way |
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Scan.fetchAllI found that the scan handle was not always properly freed. It turns out that this had to do with an error thrown when callingscanNextdue to no records have been found (related issue #77), which prevented the code from executing the scanFree call.So here we simply add a try-finally to make sure it is always being called.