Update to dalek 2.x crates #180
Conversation
andrewwhitehead
force-pushed
the
upd/dalek2
branch
from
49af474 to
36b37af
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
upd/dalek2
branch
from
36b37af to
650bcc5
Compare
| cbc = { version = "0.1", default-features = false, optional = true } | ||
| chacha20 = { version = "0.9" } # should match dependency of chacha20poly1305 | ||
| chacha20 = { version = "0.9" } # should match dependency of chacha20poly1305 |
There was a problem hiding this comment.
not a change you introduced, but chacha20 does not match chacha20poly1305. Maybe we should remove the comment? The latest chacha20 is 0.9.1 and chacha20poly1305 is on 0.10.1.
There was a problem hiding this comment.
This is correct, although the comment could maybe be clearer. Because we use both both of these crates (and there isn't a re-export available), it's important to make sure that the version of chacha20 matches the version range depended upon by chacha20poly1305.
| @@ -97,25 +93,14 @@ impl Ed25519KeyPair { | |||
| /// Verify a signature against the public key | |||
| pub fn verify_signature(&self, message: &[u8], signature: &[u8]) -> bool { | |||
| if let Ok(sig) = Signature::try_from(signature) { | |||
| self.public.verify_strict(message, &sig).is_ok() | |||
| let vk = VerifyingKey::from_bytes(&self.public).unwrap(); | |||
There was a problem hiding this comment.
Is this infallable or should we return a Result<bool> for this?
There was a problem hiding this comment.
It is infallible if the public key is valid, which is verified when the struct is created. Added a comment.
| Ok(Self::from_secret_key( | ||
| SecretKey::from_bytes(sk.as_ref()).unwrap(), | ||
| )) | ||
| Ok(Self::from_secret_key((&sk).try_into().unwrap())) |
There was a problem hiding this comment.
Is this still infallible? If so, might be good to leave the comment here.
There was a problem hiding this comment.
Same here, it would only fail if &ArrayKey<U32> can't be turned into &[u8; 32]
…/dalek2 Update to dalek 2.x crates
No description provided.