Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB benchmark #204

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

rblaine95
Copy link
Contributor

@rblaine95 rblaine95 commented Nov 17, 2023

Add a benchmark using criterion to benchmark DB performance,
specifically when the DB has a large number of profiles/items/items_tags.

Benchmark is heavily based on tests/store_key.rs

Please feel free to be extremely pedantic (-Wclippy::pedantic -Wclippy::nursery)

Related to #195

@rblaine95 rblaine95 force-pushed the benchmark branch 9 times, most recently from 62ff7c6 to 6a610b8 Compare November 20, 2023 10:03
Add a benchmark using `criterion` to benchmark DB performance,
specifically when the DB has a large number of profiles/items/items_tags
* Set `bench = false`
  * https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options

Signed-off-by: Robbie Blaine <robbieblaine.rb@gmail.com>
@swcurran
Copy link
Contributor

Thanks! Awesome stuff. We’ll watch for it transitioning from in progress to ready for review.

@rblaine95 rblaine95 marked this pull request as ready for review November 21, 2023 07:26
@andrewwhitehead andrewwhitehead merged commit 5d3709a into openwallet-foundation:main Nov 22, 2023
28 checks passed
@rblaine95 rblaine95 deleted the benchmark branch November 23, 2023 06:44
jamshale pushed a commit to jamshale/askar that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants