Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish action #334

Closed
wants to merge 1 commit into from
Closed

Update publish action #334

wants to merge 1 commit into from

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Dec 10, 2024

This needs the logic removed from build.yml (the actual publishing part, not the release creating part)

Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones requested a review from jamshale December 10, 2024 04:08
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to look at the pypi config yet, but this looks good 👍

@andrewwhitehead
Copy link
Contributor

The logic in build.yml publishes packages for multiple platforms. We also don't support poetry (yet) although there's a PR starting that work.

@swcurran
Copy link
Contributor

@andrewwhitehead — could you explain what your comment above means — what are the ramifications of what you are saying. I think I’m reading it that we need to remove the multiple platforms and the poetry update needs to be completed?

@andrewwhitehead
Copy link
Contributor

We need to keep publishing the multiple platform packages. I'm not certain whether this new publishing method requires poetry or it can still support the old packaging method.

@jamshale
Copy link
Contributor

I don't think this publishing method requires poetry. It's just how it's configured in pypi and with github actions. In theory the pypi publishing can just be removed from the build.yml pipeline and it can publish after, leaving the other platforms unchanged.

I haven't had the chance to study this yet though, so I could be off.

@ryjones
Copy link
Contributor Author

ryjones commented Dec 11, 2024

I don't think this publishing method requires poetry. It's just how it's configured in pypi and with github actions. In theory the pypi publishing can just be removed from the build.yml pipeline and it can publish after, leaving the other platforms unchanged.

I haven't had the chance to study this yet though, so I could be off.

That was my thought - the completion of the other job could trigger the pypi job

@jamshale
Copy link
Contributor

I'm working on another PR for this...

@swcurran
Copy link
Contributor

@jamshale did a separate PR that handled the changes needed, and @andrewwhitehead updated the PyPi settings, so we should be good to go -- without this. We'll see how the release goes...

@swcurran swcurran closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants