Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto commit txn on aexit #52

Closed
wants to merge 1 commit into from
Closed

feat: auto commit txn on aexit #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions wrappers/python/aries_askar/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,4 +626,11 @@ async def __aenter__(self) -> Session:
async def __aexit__(self, exc_type, exc, tb):
session = self._session
self._session = None

if session.is_transaction and session.handle:
if exc:
await session.rollback()
else:
await session.commit()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the close() should be in an else block, as commit and rollback both close the session.

await session.close()