fix: check handshake protocols array is not empty (#1948)

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
openwallet-foundation · Jul 17, 2024 · 15d0a54 · 15d0a54
1 parent a5235e7
commit 15d0a54
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/pink-icons-hope.md b/.changeset/pink-icons-hope.md
@@ -0,0 +1,5 @@
+---
+'@credo-ts/core': patch
+---
+
+Treat an empty received handshake_protocols array as undefined
diff --git a/packages/core/src/modules/oob/OutOfBandApi.ts b/packages/core/src/modules/oob/OutOfBandApi.ts
@@ -548,7 +548,7 @@ export class OutOfBandApi {
 
     await this.outOfBandService.updateState(this.agentContext, outOfBandRecord, OutOfBandState.PrepareResponse)
 
-    if (handshakeProtocols) {
+    if (handshakeProtocols && handshakeProtocols.length > 0) {
       this.logger.debug('Out of band message contains handshake protocols.')
 
       let connectionRecord
@@ -557,7 +557,7 @@ export class OutOfBandApi {
           `Connection already exists and reuse is enabled. Reusing an existing connection with ID ${existingConnection.id}.`
         )
 
-        if (!messages) {
+        if (!messages || messages?.length === 0) {
           this.logger.debug('Out of band message does not contain any request messages.')
           const isHandshakeReuseSuccessful = await this.handleHandshakeReuse(outOfBandRecord, existingConnection)
 
@@ -594,7 +594,7 @@ export class OutOfBandApi {
         })
       }
 
-      if (messages) {
+      if (messages && messages.length > 0) {
         this.logger.debug('Out of band message contains request messages.')
         if (connectionRecord.isReady) {
           await this.emitWithConnection(outOfBandRecord, connectionRecord, messages)