fix(anoncreds): wrong key name for predicates in proof object (#1517)

Signed-off-by: Martin Auer <martin.auer97@gmail.com>
openwallet-foundation · Jul 26, 2023 · d895c78 · d895c78
1 parent 6795426
commit d895c78
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/anoncreds/src/models/exchange.ts b/packages/anoncreds/src/models/exchange.ts
@@ -87,7 +87,7 @@ export interface AnonCredsProof {
     >
     self_attested_attrs: Record<string, string>
 
-    requested_predicates: Record<string, { sub_proof_index: number }>
+    predicates: Record<string, { sub_proof_index: number }>
   }
   // TODO: extend types for proof property
   proof: any

diff --git a/packages/indy-sdk/src/anoncreds/services/IndySdkHolderService.ts b/packages/indy-sdk/src/anoncreds/services/IndySdkHolderService.ts
@@ -156,7 +156,8 @@ export class IndySdkHolderService implements AnonCredsHolderService {
         indyProof,
       })
 
-      return indyProof
+      // FIXME IndyProof if badly typed in indy-sdk. It contains a `requested_predicates` property, which should be `predicates`.
+      return indyProof as unknown as AnonCredsProof
     } catch (error) {
       agentContext.config.logger.error(`Error creating Indy Proof`, {
         error,

diff --git a/packages/indy-sdk/src/anoncreds/services/IndySdkVerifierService.ts b/packages/indy-sdk/src/anoncreds/services/IndySdkVerifierService.ts
@@ -1,4 +1,4 @@
-import type { AnonCredsVerifierService, VerifyProofOptions } from '@aries-framework/anoncreds'
+import type { AnonCredsProof, AnonCredsVerifierService, VerifyProofOptions } from '@aries-framework/anoncreds'
 import type { AgentContext } from '@aries-framework/core'
 import type { CredentialDefs, Schemas, RevocRegDefs, RevRegs, IndyProofRequest, IndyProof } from 'indy-sdk'
 
@@ -82,7 +82,8 @@ export class IndySdkVerifierService implements AnonCredsVerifierService {
 
       return await this.indySdk.verifierVerifyProof(
         options.proofRequest as IndyProofRequest,
-        options.proof as IndyProof,
+        // FIXME IndyProof if badly typed in indy-sdk. It contains a `requested_predicates` property, which should be `predicates`.
+        options.proof as unknown as IndyProof,
         indySchemas,
         indyCredentialDefinitions,
         indyRevocationDefinitions,