-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme packages #1206
docs: update readme packages #1206
Conversation
Signed-off-by: Karim Stekelenburg <karim@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was just forgotten. Good catch :).
Also, I think the order you did is correct and just keep adding at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few errors I noticed when looking at the rendered version.
Would be good also to review all the RFCs we support (e.g. Present Proof V2 is not yet there) and add them to the list but I think it could be part of a separate PR.
Co-authored-by: Ariel Gentile <gentilester@gmail.com> Signed-off-by: Karim Stekelenburg <karim@animo.id>
Co-authored-by: Ariel Gentile <gentilester@gmail.com> Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 88.91% 87.57% -1.34%
==========================================
Files 708 726 +18
Lines 16614 17350 +736
Branches 2809 2972 +163
==========================================
+ Hits 14773 15195 +422
- Misses 1734 2013 +279
- Partials 107 142 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I noticed only the
core
,node
andreact-native
packages were listed in theREADME.md
. I'm not sure if this was done on purpose or just forgotten. I've added thebbs-signatures
,action-menu
,question-answer
, andtenants
modules and updated thetenants
roadmap state from 🚧 to ✅. Please comment/reject if this is incorrect.Also, I've just appended the missing modules to the table for now. I'm not sure about the ordering of these modules/table rows. One approach is to order them alphabetically, but my personal preference is to order them by relevance.
Example:
core
-- as you'll always need itnode
&react-native
(in random order) -- as you'll always need one of the twoSigned-off-by: Karim Stekelenburg karim@animo.id