Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate injectionContainer on agent #1241

Conversation

TimoGlastra
Copy link
Contributor

Marks the agent.injectionContainer as deprecated. We now have the dependencyManager that wraps the injection container from tsyringe.

This doesn't remove the property yet, but updates all usage of it in the codebase and marks it as deprecated so we can remove it in 0.4.0.

Signed-off-by: Timo Glastra <timo@animo.id>
@jleach
Copy link
Contributor

jleach commented Jan 25, 2023

I didn't notice the deprecated API in 0.3.3. If you add the following VSCode will annotate it as deprecated. In any case I've updated Bifold to use dependencyManager and it seems to be working fine. Nice work!

/**
 * @deprecated The function should not be used
 */

@karimStekelenburg
Copy link
Contributor

Strange... I'm also not seeing VSCode warnings although the @deprecated tag seems to have been added in packages/core/src/agent/BaseAgent.ts...

Copy link
Contributor

@karimStekelenburg karimStekelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra
Copy link
Contributor Author

I didn't notice the deprecated API in 0.3.3.

Version 0.3.3 didn't have the @deprecated tag yet! I noticed in your issue that it was still available, and it should have been removed already in 0.3.0. This will give everyone that updates to 0.3.4 (when we release it) a warning to upgrade before 0.4.0

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #1241 (2d2fbf4) into main (0f6d231) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   87.66%   87.64%   -0.02%     
==========================================
  Files         739      739              
  Lines       17619    17619              
  Branches     2992     2992              
==========================================
- Hits        15445    15443       -2     
- Misses       2167     2169       +2     
  Partials        7        7              
Impacted Files Coverage Δ
packages/core/src/agent/BaseAgent.ts 92.94% <ø> (-2.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra merged commit b6ae948 into openwallet-foundation:main Jan 26, 2023
@TimoGlastra TimoGlastra deleted the chore/deprecate-injection-container branch January 26, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants