Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small updates to cheqd module and demo #1439

Merged
merged 5 commits into from
May 8, 2023
Merged

fix: small updates to cheqd module and demo #1439

merged 5 commits into from
May 8, 2023

Conversation

TimoGlastra
Copy link
Contributor

No description provided.

@TimoGlastra
fix: small updates to cheqd module and demo
2732a4c 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner April 25, 2023 17:50
@TimoGlastra TimoGlastra marked this pull request as draft April 25, 2023 17:51
@TimoGlastra
Copy link
Contributor Author

Draft as there's one failing test with the cheqd moduel

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #1439 (a6dcb42) into main (4145957) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   85.54%   85.55%           
=======================================
  Files         886      886           
  Lines       21151    21156    +5     
  Branches     3635     3635           
=======================================
+ Hits        18094    18099    +5     
  Misses       2882     2882           
  Partials      175      175
Impacted Files Coverage Δ
packages/askar/src/wallet/AskarWallet.ts 65.39% <0.00%> (ø)
packages/cheqd/src/dids/CheqdDidRegistrar.ts 75.65% <100.00%> (+0.87%) ⬆️
packages/cheqd/src/dids/CheqdDidResolver.ts 51.76% <100.00%> (ø)
packages/cheqd/src/dids/didCheqdUtil.ts 81.15% <100.00%> (+0.27%) ⬆️

@TimoGlastra TimoGlastra mentioned this pull request Apr 26, 2023
Closed
@TimoGlastra
fix: consistent context
7d66535 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra marked this pull request as ready for review April 26, 2023 21:31
genaris
genaris reviewed Apr 28, 2023
View reviewed changes
package.json Outdated
@@ -60,9 +60,10 @@
"ws": "^8.13.0"
},
"resolutions": {
"@types/node": "^16.11.7"
"@types/node": "^16.11.7",
"ref-napi": "npm:@2060.io/ref-napi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the ref-napi trick must still be left to the CI script, right?

genaris
genaris reviewed Apr 28, 2023
View reviewed changes
yarn.lock Outdated
version "3.0.3"
resolved "https://registry.yarnpkg.com/ref-napi/-/ref-napi-3.0.3.tgz#e259bfc2bbafb3e169e8cd9ba49037dd00396b22"
integrity sha512-LiMq/XDGcgodTYOMppikEtJelWsKQERbLQsYm0IOOnzhwE9xYZC7x8txNnFC9wJNOkPferQI4vD4ZkC0mDyrOA==
ref-napi@3.0.3, "ref-napi@^2.0.1 || ^3.0.2", ref-napi@^3.0.3, "ref-napi@npm:@2060.io/ref-napi":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, resolve to regular ref-napi unless working on node 18.

genaris
genaris reviewed Apr 28, 2023
View reviewed changes
DEVREADME.md
@@ -74,6 +74,14 @@ docker exec indy-pool add-did-from-seed 000000000000000000000000Trustee9 TRUSTEE
# docker exec indy-pool add-did "NkGXDEPgpFGjQKMYmz6SyF" "CrSA1WbYYWLJoHm16Xw1VEeWxFvXtWjtsfEzMsjB5vDT"
```

### Setup Cheqd Ledger

In addition, there's also a docker command to run a cheqd test network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also have an advice about skipping cheqd tests like we did for postgres

@TimoGlastra TimoGlastra mentioned this pull request May 2, 2023
Closed
TimoGlastra added 3 commits May 4, 2023 17:59
@TimoGlastra
Merge remote-tracking branch 'upstream/main' into fix/small-cheqd-fixes
27ef623
@TimoGlastra
pr feedback
068fdc8 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
fix ref-napi
a6dcb42 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from genaris May 6, 2023 16:31
@genaris genaris merged commit 61daf0c into openwallet-foundation:main May 8, 2023
TimoGlastra added a commit that referenced this pull request May 16, 2023
@TimoGlastra @karimStekelenburg
@genaris @jimezesinachi @ryjones @dependabot @KimEbert42 @GramThanos @github-actions @Vickysomtee @KolbyRKunz @berendsliedrecht @jleach @auer-martin @niall-shaw @Zzocker @morrieinmaas @NB-MikeRichardson @Amit-Padmani @DaevMithran @AlexanderShenshin
feat: DIDComm V2 messaging support (#1458)
d6e2b67 
Co-authored-by: Karim Stekelenburg <karim@animo.id>
Co-authored-by: Ariel Gentile <gentilester@gmail.com>
Co-authored-by: Timo Glastra <timo@animo.id>
Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Ebert <kim@developmint.work>
Co-authored-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Victor Anene <62852943+Vickysomtee@users.noreply.github.com>
Co-authored-by: Jim Ezesinachi <jim@animo.id>
Co-authored-by: KolbyRKunz <KolbyKunz@yahoo.com>
Co-authored-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com>
Co-authored-by: Jason C. Leach <jason.leach@fullboar.ca>
Co-authored-by: Martin Auer <martin.auer97@gmail.com>
Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com>
Co-authored-by: Pritam Singh <43764373+Zzocker@users.noreply.github.com>
Co-authored-by: Mo <10432473+morrieinmaas@users.noreply.github.com>
Co-authored-by: NB-MikeRichardson <93971245+NB-MikeRichardson@users.noreply.github.com>
Co-authored-by: Amit-Padmani <106090107+Amit-Padmani@users.noreply.github.com>
Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com>
Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com>
fix(openid4vc-client): set package to private (#1210)
fix: fix typing issues with typescript 4.9 (#1214)
Fixes #1205
resolver (#1247)
fix: set updateAt on records when updating a record (#1272)
fix(transport)!: added docs moved connection to connectionId (#1222)
fix(indy-vdr): export relevant packages from root (#1291)
fix(askar): generate nonce suitable for anoncreds (#1295)
resolver and registrar for did:indy (#1253)
fix: imports from core (#1303)
fix: thread id improvements (#1311)
fix: loosen base64 validation (#1312)
fix(samples): dummy module response message type (#1321)
fix: seed and private key validation and return type in registrars (#1324)
fix!: don't emit legacy did:sov prefix for new protocols (#1245)
fix(askar): anoncrypt messages unpacking (#1332)
fix: expose indy pool configs and action menu messages (#1333)
fix: create new socket if socket state is 'closing' (#1337)
fix(anoncreds): include prover_did for legacy indy (#1342)
fix(indy-sdk): import from core (#1346)
fix(anoncreds-rs): save revocation registry index (#1351)
fix: isNewSocket logic (#1355)
fix(tenant): Correctly configure storage for multi tenant agents (#1359)
Fixes hyperledger#1353
fix(anoncreds): Buffer not imported from core (#1367)
fix(core): repository event when calling deleteById (#1356)
fix(askar): custom error handling (#1372)
fix: return HTTP 415 if unsupported content type (#1313)
fix: remove named capture groups (#1378)
fix example usage of indy-sdk-react-native package (#1382)
fix: connection id in sessions for new connections (#1383)
fix: did cache key not being set correctly (#1394)
fix: incorrect type for anoncreds registration (#1396)
fix: reference to indyLedgers in IndyXXXNotConfiguredError (#1397)
fix: add reflect-metadata (#1409)
fix: various anoncreds revocation fixes (#1416)
fix: jsonld credential format identifier version (#1412)
fix: remove `deleteOnFinish` and added documentation (#1418)
fix(askar): default key derivation method (#1420)
fix(anoncreds): make revocation status list inline with the spec (#1421)
fix(anoncreds-rs): revocation status list as JSON (#1422)
fix: issuance with unqualified identifiers (#1431)
fix(connections): store imageUrl when using DIDExchange (#1433)
fix(indy-vdr): do not force indy-vdr version (#1434)
fix: small issues with migration and WAL files (#1443)
fix: migration of link secret (#1444)
fix: Emit RoutingCreated event for mediator routing record (#1445)
fix: small updates to cheqd module and demo (#1439)
fix: remove scope check from response (#1450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genaris genaris genaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimoGlastra @codecov-commenter @genaris