feat: add Ed25519Signature2020 support #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
dbluhm
changed the title
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TimoGlastra
requested changes
Sep 11, 2024
packages/core/src/modules/vc/data-integrity/signature-suites/ed25519/Ed25519Signature2020.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
force-pushed
the
feature/ed25519-signature-2020
branch
from
e018069
to
93f571e
Compare
TimoGlastra
approved these changes
Sep 26, 2024
TimoGlastra
merged commit 715be31
into
openwallet-foundation:main
13 of 14 checks passed
|
Thanks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat naive implementation of adding Ed25519Signature2020 support to the W3cCredentialsModule. Feedback is most welcome and any direction you'd be willing to offer on what other things are required to get this to a merge-able state would be appreciated.