-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better tests for SVG attributes #990
Conversation
oh err "'attrProp' is of type 'unknown'." says Typescript now. I guess I need to tell it a type somehow? |
Argh, f#&$ing TypeScript... Unfortunately, it doesn't attribute types for |
I was toying around to figure out how to assign the string type, but I had no idea it is |
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
I was about to comment on this PR if I should have updated element.json instead of implementing replacements here. |
Oh! Yes, that would probably be the better option for the non-xlink attributes...I forgot that was a thing, and I'm the one who implemented it! 😆 |
Working on a PR to use that instead! |
This PR fixes some SVG attribute tests: