more efficient check for constant entries

openwebwork · Feb 4, 2024 · 7da067c · 7da067c
1 parent 053cfdf
commit 7da067c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/Parser/List/Vector.pm b/lib/Parser/List/Vector.pm
@@ -22,10 +22,9 @@ sub _check {
 			$type = (($type =~ m/^[aeiou]/i) ? "an " : "a ") . $type;
 			$self->{equation}->Error([ "Coordinates of Vectors must be Numbers, not %s", $type ]);
 		}
-		if ($self->context->flag("requireConstantEntries") && !($x->{isConstant})) {
-			$self->{equation}->Error("Coordinates of Vectors must be constant");
-		}
 	}
+	$self->{equation}->Error("Coordinates of Vectors must be constant")
+		if ($self->context->flag("requireConstantEntries") && !($self->{isConstant}));
 }
 
 sub ijk {