Merge pull request #1027 from drgrice1/bugfix/protect-error-html-try-2

Another attempt at fixing `student_ans` HTML escaping issues.
openwebwork · Mar 27, 2024 · e1dcbbb · e1dcbbb
2 parents df9c40d + 74a0365
commit e1dcbbb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/Value/AnswerChecker.pm b/lib/Value/AnswerChecker.pm
@@ -182,6 +182,7 @@ sub cmp_parse {
 			$self->cmp_diagnostics($ans);
 		}
 	} else {
+		$ans->{student_ans} = protectHTML($ans->{student_ans});
 		$self->cmp_collect($ans);
 		$self->cmp_error($ans);
 	}
@@ -337,8 +338,6 @@ sub cmp_error {
 			. protectHTML(substr($string, $s, $e - $s))
 			. '</SPAN>'
 			. protectHTML(substr($string, $e));
-	} else {
-		$ans->{student_ans} = protectHTML($ans->{student_ans});
 	}
 	$self->cmp_Error($ans, $message);
 }