Update the sample problems to use the pg-codemirror-editor with CodeMirror 6. #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
reviewed
Nov 26, 2024
Comment on lines
10
to
13
| <script | ||
| src="https://cdn.jsdelivr.net/npm/@openwebwork/pg-codemirror-editor@0.0.1-beta.26/dist/pg-codemirror-editor.js" | ||
| defer | ||
| > |
There was a problem hiding this comment.
I assume there is no better way than to hard code the version here, just feel this could get overlooked during a release.
There was a problem hiding this comment.
Unfortunately, there isn't. This isn't like the packages installed by npm where the version is automatically handled by the package system. I don't really like it either, although, it was previously a hard coded version of the CodeMirror 5 package that was there. So it doesn't really change anything with that.
I plan to remove the beta version before the next release, and once there is a stable version here it should be fine.
drgrice1
force-pushed
the
sample-problems-use-pg-codemirror
branch
2 times, most recently
from
c49f958 to
643a5ff
Compare
drgrice1
force-pushed
the
sample-problems-use-pg-codemirror
branch
2 times, most recently
from
de3eadb to
2a4dd2b
Compare
Alex-Jordan
approved these changes
Dec 11, 2024
drgrice1
force-pushed
the
sample-problems-use-pg-codemirror
branch
from
2a4dd2b to
b50c40e
Compare
drgrice1
force-pushed
the
sample-problems-use-pg-codemirror
branch
from
b50c40e to
ff90af1
Compare
drgrice1
force-pushed
the
sample-problems-use-pg-codemirror
branch
from
ff90af1 to
5a2ff84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the script and generated tutorial code to use the pg-codemirror-editor package which uses CodeMirror 6, rather than using CodeMirror 5. This script is used to generate the html sample problem pages linked to on the webwork wiki.