Fix a bug for custom GraphTool tools that derive from a built in tool. #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
changed the title
The handleKeyEvent method needs to pass the event on to the super class in case the super class uses it (it usually will).
drgrice1
force-pushed
the
bugfix/graphtool-derived-customtool
branch
from
964a80a to
ac80a2e
Compare
pstaabp
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handleKeyEvent method needs to pass the event on to the super class in case the super class uses it (it usually will).
This does not affect any of the built in tools, so there is nothing to test for this pull request. It is just the way it should be in case someone wants to use this as it was intended.